Skip to content

fix: resolve NeMo Hydra target interpolation#1494

Open
mldangelo-oai wants to merge 2 commits into
mainfrom
mdangelo/codex/fix-nemo-hydra-targets-c191
Open

fix: resolve NeMo Hydra target interpolation#1494
mldangelo-oai wants to merge 2 commits into
mainfrom
mdangelo/codex/fix-nemo-hydra-targets-c191

Conversation

@mldangelo-oai
Copy link
Copy Markdown
Contributor

@mldangelo-oai mldangelo-oai commented May 31, 2026

Summary

  • resolve simple Hydra/OmegaConf target interpolations before dangerous/safe classification
  • fail closed on unresolved dynamic target selectors such as resolver expressions, missing references, cycles, or excessive depth
  • pin torch.utils.cpp_extension.load_inline as non-clean and preserve safe target negatives

Validation

  • focused C191/C194 slice: 10 passed, 200 deselected
  • PYTHONPATH=/private/tmp/modelaudit-c191 PROMPTFOO_DISABLE_TELEMETRY=1 /Users/mdangelo/code/modelaudit/.venv/bin/pytest tests/scanners/test_nemo_scanner.py -q: 210 passed
  • ruff format --check modelaudit/scanners/nemo_scanner.py tests/scanners/test_nemo_scanner.py
  • ruff check modelaudit/scanners/nemo_scanner.py tests/scanners/test_nemo_scanner.py
  • mypy modelaudit/scanners/nemo_scanner.py tests/scanners/test_nemo_scanner.py
  • git diff --check

@mldangelo-oai
Copy link
Copy Markdown
Contributor Author

mldangelo-oai commented May 31, 2026

@codex review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 31, 2026 •
edited
Loading

Workflow run and artifacts

Performance Benchmarks

Compared 12 shared benchmarks with a regression threshold of 15%.
Status: 0 regressions, 0 improved, 12 stable, 0 new, 0 missing.
Aggregate shared-benchmark median: 773.09ms -> 759.70ms (-1.7%).

Workload Benchmark Target Size Files Baseline Current Change Status
chunked-upload-stream tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_chunked_upload_stream chunked_stream 278.2 KiB 1 22.33ms 23.40ms +4.8% stable
suspicious-pickle-intake tests/benchmarks/test_scan_benchmarks.py::test_scan_suspicious_pickle_intake suspicious-intake 183.8 KiB 4 104.54ms 100.29ms -4.1% stable
warm-cache-rescan tests/benchmarks/test_scan_benchmarks.py::test_scan_warm_cached_repository_rescan release-candidate 547.3 KiB 32 65.75ms 64.10ms -2.5% stable
duplicate-heavy-registry tests/benchmarks/test_scan_benchmarks.py::test_scan_duplicate_registry_snapshot registry-snapshot 915.2 KiB 13 222.17ms 216.80ms -2.4% stable
nested-payload-review tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_nested_payload_review[nested_base64] nested_base64 98 B 1 423.0us 413.6us -2.2% stable
single-checkpoint-preflight tests/benchmarks/test_scan_benchmarks.py::test_scan_single_checkpoint_before_load single_checkpoint.pkl 183.0 KiB 1 41.82ms 41.01ms -1.9% stable
clean-training-checkpoint tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_clean_training_checkpoint safe_large 278.2 KiB 1 19.35ms 19.65ms +1.5% stable
padded-multi-stream-upload tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_padded_multi_stream_upload multi_stream_padded 4.1 KiB 1 1.55ms 1.53ms -1.0% stable
direct-malicious-upload tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_direct_malicious_upload malicious_reduce 52 B 1 1.45ms 1.43ms -1.0% stable
mixed-model-repository tests/benchmarks/test_scan_benchmarks.py::test_scan_release_candidate_repository release-candidate 547.3 KiB 32 292.88ms 290.25ms -0.9% stable
nested-payload-review tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_nested_payload_review[nested_hex] nested_hex 130 B 1 419.1us 422.4us +0.8% stable
nested-payload-review tests/benchmarks/test_picklescan_benchmarks.py::test_picklescan_nested_payload_review[nested_raw] nested_raw 78 B 1 412.1us 412.1us +0.0% stable

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed May 31, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bf81544369

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modelaudit/scanners/nemo_scanner.py Outdated
Comment thread modelaudit/scanners/nemo_scanner.py Outdated
Comment thread modelaudit/scanners/nemo_scanner.py
@mldangelo-oai mldangelo-oai marked this pull request as ready for review May 31, 2026 14:52
ianw-oai
ianw-oai approved these changes Jun 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ianw-oai ianw-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed; this looks acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@ianw-oai ianw-oai ianw-oai approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mldangelo-oai @ianw-oai